EMSUSD-1522 I want the ability to see and set the expansion rule of the collection #4015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
barbalt
commented
Nov 27, 2024
barbalt
commented
- Added tabs to the Light Linking widget
- Added Expression tabs
- Added Expansion rules menu
...urces/ae/usd-shared-components/src/python/usdSharedComponents/collection/ExpressionWidget.py
Show resolved
Hide resolved
...urces/ae/usd-shared-components/src/python/usdSharedComponents/collection/ExpressionWidget.py
Show resolved
Hide resolved
...s/ae/usd-shared-components/src/python/usdSharedComponents/collection/IncludeExcludeWidget.py
Outdated
Show resolved
Hide resolved
| headerLayout.addWidget(menuButton) | ||
| includeExcludeLayout.addWidget(headerWidget) | ||
|
|
||
| self._include = StringList(includes, "Include", "Include all", self) |
There was a problem hiding this comment.
I would have like the widget class to have names that reflect they are UI element. StringList and Resizable are very generic, at first I did not understand what was going on. For example StringListView.
(Also, its file is just "list.py" which triggers my consistency demon. :) )
There was a problem hiding this comment.
Those were there on the initial version of this widget that was moved to maya. So I kept them with the same name for ease of updating
lib/mayaUsd/resources/ae/usd-shared-components/src/python/usdSharedComponents/common/list.py
Show resolved
Hide resolved
pierrebai-adsk
previously approved these changes
Nov 28, 2024
pierrebai-adsk
previously approved these changes
Nov 28, 2024
| @@ -1,5 +1,5 @@ | |||
| try: | |||
| from PySide6.QtCore import QSettings | |||
| from PySide6.QtCore import QSettings # type: ignore | |||
| except: | |||
| from PySide2.QtCore import QSettings # type: ignore | |||
|
|
|||
There was a problem hiding this comment.
I discovered that this writes files in a random folder. I think we will need to have some DCC-specific callback to save the data in DCC-specific locations. (In another PR)
pierrebai-adsk
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.